-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Transmit and render array field values in log entries #81385
[Logs UI] Transmit and render array field values in log entries #81385
Conversation
The values will be returned as arrays of strings to match the response of the log entries API. The UI is now responsible to decide how render the fields.
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your additions LGTM and I don't yet regret any of my own changes. 😬 Log entries seem to render correctly everywhere I remembered to check. GitHub won't let me approve my own PR, though. 😉
Thanks again for picking this up! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works correctly 👍
…tic#81385) Co-authored-by: Alejandro Fernández Gómez <[email protected]>
#81385) (#81893) Co-authored-by: Alejandro Fernández Gómez <[email protected]> Co-authored-by: Felix Stürmer <[email protected]>
…#81385) (#81892) Co-authored-by: Alejandro Fernández Gómez <[email protected]> Co-authored-by: Felix Stürmer <[email protected]>
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
Summary
This ensures that all field values that are retrieved via the
fields
parameter are used instead of only the first one.closes #79838