Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Transmit and render array field values in log entries #81385

Merged
merged 23 commits into from
Oct 28, 2020

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Oct 21, 2020

Summary

This ensures that all field values that are retrieved via the fields parameter are used instead of only the first one.

closes #79838

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 21, 2020
@weltenwort weltenwort added this to the Logs UI 7.10 milestone Oct 21, 2020
@weltenwort weltenwort self-assigned this Oct 21, 2020
The values will be returned as arrays of strings to match the response
of the log entries API. The UI is now responsible to decide how render
the fields.
@afgomez afgomez marked this pull request as ready for review October 27, 2020 15:29
@afgomez afgomez requested a review from a team as a code owner October 27, 2020 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
infra 1143 1145 +2

async chunks size

id before after diff
infra 2.8MB 2.8MB +868.0B

page load bundle size

id before after diff
infra 178.8KB 179.0KB +238.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Oct 27, 2020
Copy link
Member Author

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your additions LGTM and I don't yet regret any of my own changes. 😬 Log entries seem to render correctly everywhere I remembered to check. GitHub won't let me approve my own PR, though. 😉

Thanks again for picking this up! ❤️

Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly 👍

@afgomez afgomez merged commit 756c3f1 into elastic:master Oct 28, 2020
afgomez added a commit to afgomez/kibana that referenced this pull request Oct 28, 2020
afgomez pushed a commit that referenced this pull request Oct 28, 2020
#81385) (#81893)

Co-authored-by: Alejandro Fernández Gómez <[email protected]>

Co-authored-by: Felix Stürmer <[email protected]>
afgomez pushed a commit that referenced this pull request Oct 28, 2020
…#81385) (#81892)

Co-authored-by: Alejandro Fernández Gómez <[email protected]>

Co-authored-by: Felix Stürmer <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals

* 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits)
  fixed jest
  APM Experiments settings (elastic#81554)
  [Resolver] Enable resolver test plugin tests (elastic#81339)
  Add TS project references for inspector  (elastic#81792)
  Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835)
  [Fleet] Rename ingestManager translations fleet (elastic#81837)
  [Logs UI] Transmit and render array field values in log entries (elastic#81385)
  Audit Logging: use the original url (elastic#81282)
  [User experience] Fix JS error rate (elastic#81512)
  [UX] Add median/percentile info in titles (elastic#79824)
  Support export for SO with circular refs (elastic#81582)
  Get rid of  global types (elastic#81739)
  [APM] Fix precommit script (elastic#81594)
  skips overview tests (elastic#81877)
  [Security Solution][Case] Fix connector's labeling (elastic#81824)
  Added simple test, which only covers successful case when edit happened right after task was complete previous execution
  [Maps] Fix EMS test (elastic#81856)
  [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783)
  skip flaky suite (elastic#81853)
  Fixed type checks and unit tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Multi-value fields only render the first value in the log stream and details flyout
4 participants